feat: improved handling of shapes #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rohanbabbar04 just checking you saw this :) |
Let me test this, I will get back on this tomorrow :) |
|
@mrava87, |
rohanbabbar04
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the handling of
global_shapeandlocal_shapesinDistributedArray, allowing one to pass integers instead of tuples for 1D array:For
global_shapethis was already allowed, but a bug has been identified whenlocal_shapes!=Nonesince in_check_local_shapesthis is indexed - seepylops-mpi/pylops_mpi/DistributedArray.py
Line 325 in 6d3b1e8
For
local_shapes, this is a new feature